arm64: fix types in copy_highpage()
authorTong Tiangen <tongtiangen@huawei.com>
Wed, 20 Apr 2022 03:04:13 +0000 (03:04 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Wed, 4 May 2022 19:00:13 +0000 (20:00 +0100)
commit921d161f15d6b090599f6a8c23f131969edbd1fa
tree410672eebbb3c5e598ff466faabd4084c3de90db
parent5028fbad2d57910e8c776ba1c868da0e4f64978f
arm64: fix types in copy_highpage()

In copy_highpage() the `kto` and `kfrom` local variables are pointers to
struct page, but these are used to hold arbitrary pointers to kernel memory
. Each call to page_address() returns a void pointer to memory associated
with the relevant page, and copy_page() expects void pointers to this
memory.

This inconsistency was introduced in commit 2563776b41c3 ("arm64: mte:
Tags-aware copy_{user_,}highpage() implementations") and while this
doesn't appear to be harmful in practice it is clearly wrong.

Correct this by making `kto` and `kfrom` void pointers.

Fixes: 2563776b41c3 ("arm64: mte: Tags-aware copy_{user_,}highpage() implementations")
Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Link: https://lore.kernel.org/r/20220420030418.3189040-3-tongtiangen@huawei.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/mm/copypage.c