drm/amd/display: Fix kernel panic by dal_gpio_open() error
authorTakashi Iwai <tiwai@suse.de>
Fri, 23 Oct 2020 07:46:54 +0000 (09:46 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 26 Oct 2020 21:19:02 +0000 (17:19 -0400)
commit920bb38c518408fa2600eaefa0af9e82cf48f166
tree2896941b5526726df452df380512971a3d42bcac
parent0689dcf3e4d6b89cc2087139561dc12b60461dca
drm/amd/display: Fix kernel panic by dal_gpio_open() error

Currently both error code paths handled in dal_gpio_open_ex() issues
ASSERT_CRITICAL(), and this leads to a kernel panic unnecessarily if
CONFIG_KGDB is enabled.  Since basically both are non-critical errors
and can be recovered, drop those assert calls and use a safer one,
BREAK_TO_DEBUGGER(), for allowing the debugging, instead.

BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1177973
Cc: <stable@vger.kernel.org>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c