iscsi-target: Reject zero-length payloads during SecurityNegotiation
authorNicholas Bellinger <nab@linux-iscsi.org>
Wed, 28 May 2014 19:07:40 +0000 (12:07 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 4 Jun 2014 02:18:43 +0000 (19:18 -0700)
commit91f0abfda1709131edbd62ad3515da2b8e6c0261
treeb3d63f7b7841ad446dd18bf1c0f51a67d3b4be82
parent51a07f84649d2be206c4c2ad9a612956db0c2f8c
iscsi-target: Reject zero-length payloads during SecurityNegotiation

This patch changes iscsi_target_handle_csg_zero() to explicitly
reject login requests in SecurityNegotiation with a zero-length
payload, following the language in RFC-3720 Section 8.2:

  Whenever an iSCSI target gets a response whose keys, or their
  values, are not according to the step definition, it MUST answer
  with a Login reject with the "Initiator Error" or "Missing Parameter"
  status.

Previously when a zero-length login request in CSG=0 was received,
the target would send a login response with CSG=0 + T_BIT=0 asking
the initiator to complete authentication, and not fail the login
until MAX_LOGIN_PDUS was reached.  This change will now immediately
fail the login attempt with ISCSI_STATUS_CLS_INITIATOR_ERR status.

Reported-by: Tejas Vaykole <tejas.vaykole@calsoftinc.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_nego.c