ext4: don't call fscrypt_get_encryption_info() from dx_show_leaf()
authorEric Biggers <ebiggers@google.com>
Thu, 3 Dec 2020 02:20:36 +0000 (18:20 -0800)
committerEric Biggers <ebiggers@google.com>
Thu, 3 Dec 2020 02:25:01 +0000 (18:25 -0800)
commit91d0d89241b4201d612bfac623199c84363286e9
treeb9c7e053569b97dc2d2a4af5dca829165ddd0ccb
parenta302052b9586f2fdf8c3a7d9b907e71b25d7d463
ext4: don't call fscrypt_get_encryption_info() from dx_show_leaf()

The call to fscrypt_get_encryption_info() in dx_show_leaf() is too low
in the call tree; fscrypt_get_encryption_info() should have already been
called when starting the directory operation.  And indeed, it already
is.  Moreover, the encryption key is guaranteed to already be available
because dx_show_leaf() is only called when adding a new directory entry.

And even if the key wasn't available, dx_show_leaf() uses
fscrypt_fname_disk_to_usr() which knows how to create a no-key name.

So for the above reasons, and because it would be desirable to stop
exporting fscrypt_get_encryption_info() directly to filesystems, remove
the call to fscrypt_get_encryption_info() from dx_show_leaf().

Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201203022041.230976-5-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
fs/ext4/namei.c