Revert "qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()"
authorJia He <justin.he@arm.com>
Tue, 20 Jul 2021 13:26:55 +0000 (21:26 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Jul 2021 14:26:06 +0000 (07:26 -0700)
commit91bed5565bba03b2a9f7334b58ae4be9df7c3840
tree4f7c482a9ce3a297758a0eec568cbfbad507cbb8
parent8fb4792f091e608a0a1d353dfdf07ef55a719db5
Revert "qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()"

This reverts commit 6206b7981a36476f4695d661ae139f7db36a802d.

That patch added additional spin_{un}lock_bh(), which was harmless
but pointless. The orginal code path has guaranteed the pair of
spin_{un}lock_bh().

We'd better revert it before we find the exact root cause of the
bug_on mentioned in that patch.

Fixes: 6206b7981a36 ("qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()")
Cc: David S. Miller <davem@davemloft.net>
Cc: Prabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: Jia He <justin.he@arm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_mcp.c