tipc: fix wrong socket reference counter after tipc_sk_timeout() returns
authorTung Nguyen <tung.q.nguyen@dektech.com.au>
Thu, 28 Nov 2019 03:10:06 +0000 (10:10 +0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Nov 2019 07:09:14 +0000 (23:09 -0800)
commit91a4a3eb433e4d786420c41f3c08d1d16c605962
treeaf35c182a1071b62fcc60062ae863b85c961c407
parent2fe97a578d7bad3116a89dc8a6692a51e6fc1d9c
tipc: fix wrong socket reference counter after tipc_sk_timeout() returns

When tipc_sk_timeout() is executed but user space is grabbing
ownership, this function rearms itself and returns. However, the
socket reference counter is not reduced. This causes potential
unexpected behavior.

This commit fixes it by calling sock_put() before tipc_sk_timeout()
returns in the above-mentioned case.

Fixes: afe8792fec69 ("tipc: refactor function tipc_sk_timeout()")
Signed-off-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Acked-by: Ying Xue <ying.xue@windriver.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c