Remove BitmapSelector.Suffix property (#54364)
authorEric Erhardt <eric.erhardt@microsoft.com>
Mon, 21 Jun 2021 17:10:47 +0000 (12:10 -0500)
committerGitHub <noreply@github.com>
Mon, 21 Jun 2021 17:10:47 +0000 (12:10 -0500)
commit9199eb6952a4569cf5be57b68732989651ca55e2
tree18ebebac00f7dff517074221a44159b7baf724d7
parentdbcb38752d3303705a463ea029c83b016e99816a
Remove BitmapSelector.Suffix property (#54364)

With https://github.com/dotnet/runtime/issues/22761 and https://github.com/dotnet/corefx/pull/22833, BitmapSelector.Suffix will always be null. This means this feature is dead code, and users are unable to use it.

Removing this dead code because:

1. It doesn't do anything.
2. It is causing ILLink warnings, and it is easier to delete than to try to address the warnings.

I logged https://github.com/dotnet/runtime/issues/54363 to follow up and either re-implement this feature, or obsolete the attributes that no longer have any effect on the app.
src/libraries/System.Drawing.Common/src/ILLink/ILLink.Suppressions.xml
src/libraries/System.Drawing.Common/src/System/Drawing/BitmapSelector.cs
src/libraries/System.Drawing.Common/src/System/Drawing/ToolboxBitmapAttribute.cs