powerpc: kvm: fix rare but potential deadlock scene
authorpingfan liu <qemulist@gmail.com>
Fri, 15 Nov 2013 08:35:00 +0000 (16:35 +0800)
committerAlexander Graf <agraf@suse.de>
Mon, 18 Nov 2013 21:41:57 +0000 (22:41 +0100)
commit91648ec09c1ef69c4d840ab6dab391bfb452d554
tree05cb5c7b284901e91984039244298094a3e3604d
parentc9438092cae4a5bdbd146ca1385e85dcd6e847f8
powerpc: kvm: fix rare but potential deadlock scene

Since kvmppc_hv_find_lock_hpte() is called from both virtmode and
realmode, so it can trigger the deadlock.

Suppose the following scene:

Two physical cpuM, cpuN, two VM instances A, B, each VM has a group of
vcpus.

If on cpuM, vcpu_A_1 holds bitlock X (HPTE_V_HVLOCK), then is switched
out, and on cpuN, vcpu_A_2 try to lock X in realmode, then cpuN will be
caught in realmode for a long time.

What makes things even worse if the following happens,
  On cpuM, bitlockX is hold, on cpuN, Y is hold.
  vcpu_B_2 try to lock Y on cpuM in realmode
  vcpu_A_2 try to lock X on cpuN in realmode

Oops! deadlock happens

Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
Reviewed-by: Paul Mackerras <paulus@samba.org>
CC: stable@vger.kernel.org
Signed-off-by: Alexander Graf <agraf@suse.de>
arch/powerpc/kvm/book3s_64_mmu_hv.c
arch/powerpc/kvm/book3s_hv_rm_mmu.c