[CodeGen] add rotate builtins
authorSanjay Patel <spatel@rotateright.com>
Sun, 19 Aug 2018 13:12:40 +0000 (13:12 +0000)
committerSanjay Patel <spatel@rotateright.com>
Sun, 19 Aug 2018 13:12:40 +0000 (13:12 +0000)
commit9116f0438cee22df9e5290bf71a18203cad06559
treee390537451e660b1c3360db24a660ba669fdc1f6
parent803912ea5709b9f6d72d8e9ba74502a7d261abbd
[CodeGen] add rotate builtins

This exposes the LLVM funnel shift intrinsics as more familiar bit rotation functions in clang
(when both halves of a funnel shift are the same value, it's a rotate).

We're free to name these as we want because we're not copying gcc, but if there's some other
existing art (eg, the microsoft ops that are modified in this patch) that we want to replicate,
we can change the names.

The funnel shift intrinsics were added here:
D49242

With improved codegen in:
rL337966
rL339359

And basic IR optimization added in:
rL338218
rL340022

...so these are expected to produce asm output that's equal or better to the multi-instruction
alternatives using primitive C/IR ops.

In the motivating loop example from PR37387:
https://bugs.llvm.org/show_bug.cgi?id=37387#c7
...we get the expected 'rolq' x86 instructions if we substitute the rotate builtin into the source.

Differential Revision: https://reviews.llvm.org/D50924

llvm-svn: 340135
clang/docs/LanguageExtensions.rst
clang/include/clang/Basic/Builtins.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/builtin-rotate.c [new file with mode: 0644]
clang/test/CodeGen/ms-intrinsics-rotations.c