[lldb] Forcefully complete a type when adding typedefs
authorPavel Labath <pavel@labath.sk>
Wed, 19 Aug 2020 13:52:58 +0000 (15:52 +0200)
committerPavel Labath <pavel@labath.sk>
Thu, 20 Aug 2020 13:19:10 +0000 (15:19 +0200)
commit9109311356cc9e74818dd7450020d9b85d2f8125
tree4f6dec8c2799710572a5ce2421c57cf7d7b267a9
parent03ded5497a2f458b6af054fa7bac0da0240e7b7a
[lldb] Forcefully complete a type when adding typedefs

This is very similar to D85968, only more elusive to since we were not
adding the typedef type to the relevant DeclContext until D86140, which
meant that the DeclContext was populated (and the relevant assertion
hit) only after importing the type into the expression ast in a
particular way.

I haven't checked whether this situation can be hit in the gmodules
case, but my money is on "yes".

Differential Revision: https://reviews.llvm.org/D86216
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
lldb/test/Shell/SymbolFile/DWARF/DW_AT_declaration-with-children.s