Bluetooth: Fix HCI H5 corrupted ack value
authorLoic Poulain <loic.poulain@intel.com>
Fri, 8 Aug 2014 17:07:16 +0000 (19:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Oct 2014 16:35:12 +0000 (09:35 -0700)
commit90f9a6a427abd19c8d304ecbac034deb39d0737c
tree3a5fbf042dab21cc683646e44ce99a7d9cdab889
parent28330aa4e0dc1232ecfb18c7456a5c456f5c6e97
Bluetooth: Fix HCI H5 corrupted ack value

commit 4807b51895dce8aa650ebebc51fa4a795ed6b8b8 upstream.

In this expression: seq = (seq - 1) % 8
seq (u8) is implicitly converted to an int in the arithmetic operation.
So if seq value is 0, operation is ((0 - 1) % 8) => (-1 % 8) => -1.
The new seq value is 0xff which is an invalid ACK value, we expect 0x07.
It leads to frequent dropped ACK and retransmission.
Fix this by using '&' binary operator instead of '%'.

Signed-off-by: Loic Poulain <loic.poulain@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/bluetooth/hci_h5.c