pan/bi: Ignore signedness in vertex fetch
authorAlyssa Rosenzweig <alyssa@collabora.com>
Tue, 14 Mar 2023 02:31:28 +0000 (22:31 -0400)
committerMarge Bot <emma+marge@anholt.net>
Tue, 14 Mar 2023 23:10:00 +0000 (23:10 +0000)
commit90e78f6008cf5b2cd8a9f11b9a496a80aeee4196
tree1c51fe4a6234d957a801e23504dceb04a5212744
parent62497d48609e6ce3d06bf0ca6b6d5ea25939d06f
pan/bi: Ignore signedness in vertex fetch

We just want a bit-exact transfer for integers. Using .auto32 accomplishes this
without any clamping shenanigans. Fixes gl-3.0-vertexattribipointer.

Note we can't use .auto32 unconditionally, since reading a uint vertex as float
is supposed to convert (or something like that, gl-2.0-vertexattribpointer tests
the bad case at any rate).

Fixes: 482cc273af5 ("pan/bi: Implement load attribute with the builder")
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21891>
src/panfrost/ci/panfrost-g52-fails.txt
src/panfrost/compiler/bifrost_compile.c