[ELF] Delete relOff from TargetInfo::writePLT
authorFangrui Song <maskray@google.com>
Sat, 14 Dec 2019 23:09:43 +0000 (15:09 -0800)
committerFangrui Song <maskray@google.com>
Mon, 16 Dec 2019 19:10:02 +0000 (11:10 -0800)
commit90d195d026f5c90e26f09614e23d4112b3dfaaa1
treef4fd12eb512d7d25b8a5df81a19e40f12d654d34
parent98afa2c1f1a040afc02be10d5a58bf7e87c38cc1
[ELF] Delete relOff from TargetInfo::writePLT

This change only affects EM_386. relOff can be computed from `index`
easily, so it is unnecessarily passed as a parameter.

Both in.plt and in.iplt entries are written by writePLT. For in.iplt,
the instruction `push reloc_offset` will change because `index` is now
different. Fortunately, this does not matter because `push; jmp` is only
used by PLT. IPLT does not need the code sequence.

Reviewed By: grimar, ruiu

Differential Revision: https://reviews.llvm.org/D71518
14 files changed:
lld/ELF/Arch/AArch64.cpp
lld/ELF/Arch/ARM.cpp
lld/ELF/Arch/Hexagon.cpp
lld/ELF/Arch/Mips.cpp
lld/ELF/Arch/PPC.cpp
lld/ELF/Arch/PPC64.cpp
lld/ELF/Arch/RISCV.cpp
lld/ELF/Arch/SPARCV9.cpp
lld/ELF/Arch/X86.cpp
lld/ELF/Arch/X86_64.cpp
lld/ELF/SyntheticSections.cpp
lld/ELF/Target.h
lld/test/ELF/gnu-ifunc-i386.s
lld/test/ELF/gnu-ifunc-plt-i386.s