ncpfs: fix a braino in OOM handling in ncp_fill_cache()
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 8 Mar 2016 03:17:07 +0000 (22:17 -0500)
committerSasha Levin <sasha.levin@oracle.com>
Tue, 22 Mar 2016 15:10:30 +0000 (11:10 -0400)
commit906e5a6e6e73316fa4741ca53be014c9477a100c
tree3078c5a072246c4c4426cccfd4e38a0df14c0e4c
parent6d44ac3f884b220573b2d46c691127fb6fee0707
ncpfs: fix a braino in OOM handling in ncp_fill_cache()

[ Upstream commit 803c00123a8012b3a283c0530910653973ef6d8f ]

Failing to allocate an inode for child means that cache for *parent* is
incompletely populated.  So it's parent directory inode ('dir') that
needs NCPI_DIR_CACHE flag removed, *not* the child inode ('inode', which
is what we'd failed to allocate in the first place).

Fucked-up-in: commit 5e993e25 ("ncpfs: get rid of d_validate() nonsense")
Fucked-up-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@vger.kernel.org # v3.19
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
fs/ncpfs/dir.c