[ARM] Fix lowering of misaligned memcpy/memset
authorJohn Brawn <john.brawn@arm.com>
Fri, 26 May 2017 13:59:12 +0000 (13:59 +0000)
committerJohn Brawn <john.brawn@arm.com>
Fri, 26 May 2017 13:59:12 +0000 (13:59 +0000)
commit9009d2905debfc210859e5d20a1fb3ec319a9ce7
tree93ad3b86753bdbce6d9657acf75739ae0d92f12d
parentba9d8ba82aab927dd8e132c947cd64efff4e09d1
[ARM] Fix lowering of misaligned memcpy/memset

Currently getOptimalMemOpType returns i32 for large enough sizes without
checking for alignment, leading to poor code generation when misaligned accesses
aren't permitted as we generate a word store then later split it up into byte
stores. This means we inadvertantly go over the MaxStoresPerMemcpy limit and for
memset we splat the memset value into a word then immediately split it up
again.

Fix this by leaving it up to FindOptimalMemOpLowering to figure out which type
to use, but also fix a bug there where it wasn't correctly checking if
misaligned memory accesses are allowed.

Differential Revision: https://reviews.llvm.org/D33442

llvm-svn: 303990
llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
llvm/lib/Target/ARM/ARMISelLowering.cpp
llvm/test/CodeGen/ARM/memcpy-inline.ll
llvm/test/CodeGen/ARM/memset-inline.ll