nvme-fabrics: error out to unlock the mutex
authorChaitanya Kulkarni <kch@nvidia.com>
Fri, 2 Jun 2023 05:37:13 +0000 (22:37 -0700)
committerKeith Busch <kbusch@kernel.org>
Mon, 12 Jun 2023 17:36:59 +0000 (10:36 -0700)
commit900095bfbbf6623fbfa9e5ceb3982f293b6f3275
treef5e023fc9eb7e307fb0d7c54866ca0b1eb028c90
parentbdbfcd5f6caa46e1ddbfd60cbf694d192b37805a
nvme-fabrics: error out to unlock the mutex

Currently, in the nvmf_host_add() function, if the nvmf_host_alloc()
call failed to allocate memory for the host, the code would directly
return -ENOMEM without unlocking the nvmf_hosts_mutex. This could
lead to potential issues with mutex synchronization.

Fix that error handling mechanism by jumping to the out_unlock label
when nvmf_host_alloc() fails. This ensures that the mutex is unlocked
before returning the error code. The updated code enhances avoids
possible deadlocks.

Fixes: f0cebf82004d ("nvme-fabrics: prevent overriding of existing host")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202306020909.MTUEBeIa-lkp@intel.com/
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Julia Lawall <julia.lawall@inria.fr>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/fabrics.c