projects / platform / kernel / linux-starfive.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c46e2a8) | patch
ath5k: fix memory leak on buf on failed eeprom read
authorColin Ian King <colin.king@canonical.com>
Wed, 3 May 2017 14:26:00 +0000 (15:26 +0100)
committerKalle Valo <kvalo@qca.qualcomm.com>
Fri, 19 May 2017 07:51:57 +0000 (10:51 +0300)
commit8fed6823e06e43ee9cf7c0ffecec2f9111ce6201
tree00651d1c25299ae80166b7e2d30614a43c53d659tree | snapshot
parentc46e2a848f29ce592f5f0db81757d17bbdbe45e4commit | diff
ath5k: fix memory leak on buf on failed eeprom read

The AR5K_EEPROM_READ macro returns with -EIO if a read error
occurs causing a memory leak on the allocated buffer buf. Fix
this by explicitly calling ath5k_hw_nvram_read and exiting on
the via the freebuf label that performs the necessary free'ing
of buf when a read error occurs.

Detected by CoverityScan, CID#1248782 ("Resource Leak")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath5k/debug.c diff | blob | history
Domain: System / Kernel;