tpm: fix error return code in tpm2_get_cc_attrs_tbl()
authorZhen Lei <thunder.leizhen@huawei.com>
Wed, 12 May 2021 13:39:26 +0000 (21:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 08:12:51 +0000 (10:12 +0200)
commit8fe5a459186a2895041e97ae8c265d79725aaed5
tree24e2e8b960da6867968b86b70b8d5d72572ae8dd
parent31c9a4b24d86cbb36ff0d7a085725a3b4f0138c8
tpm: fix error return code in tpm2_get_cc_attrs_tbl()

commit 1df83992d977355177810c2b711afc30546c81ce upstream.

If the total number of commands queried through TPM2_CAP_COMMANDS is
different from that queried through TPM2_CC_GET_CAPABILITY, it indicates
an unknown error. In this case, an appropriate error code -EFAULT should
be returned. However, we currently do not explicitly assign this error
code to 'rc'. As a result, 0 was incorrectly returned.

Cc: stable@vger.kernel.org
Fixes: 58472f5cd4f6("tpm: validate TPM 2.0 commands")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/tpm/tpm2-cmd.c