misc: ocxl: fix possible double free in ocxl_file_register_afu
authorHangyu Hua <hbh25y@gmail.com>
Mon, 18 Apr 2022 08:57:58 +0000 (16:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:23:06 +0000 (10:23 +0200)
commit8fb674216835e1f0c143762696d645facebb4685
tree13b4f5f657b1dbbce7e9c52466393f5c35fa6b0f
parent11ee8e960007b5f0a9d34078fbf02d3580b97733
misc: ocxl: fix possible double free in ocxl_file_register_afu

[ Upstream commit 950cf957fe34d40d63dfa3bf3968210430b6491e ]

info_release() will be called in device_unregister() when info->dev's
reference count is 0. So there is no need to call ocxl_afu_put() and
kfree() again.

Fix this by adding free_minor() and return to err_unregister error path.

Fixes: 75ca758adbaf ("ocxl: Create a clear delineation between ocxl backend & frontend")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220418085758.38145-1-hbh25y@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/misc/ocxl/file.c