bitops/non-atomic: make @nr unsigned to avoid any DIV
authorVineet Gupta <Vineet.Gupta1@synopsys.com>
Thu, 5 Aug 2021 19:14:08 +0000 (12:14 -0700)
committerArnd Bergmann <arnd@arndb.de>
Sat, 14 Aug 2021 11:07:42 +0000 (13:07 +0200)
commit8f76f9c46952659dd925c21c3f62a0d05a3f3e71
tree804e531533b24f68c2841facdd8a6aef88997b19
parenta71bfc0079762b4d3cb36dcc5fe6c23c806cfc8c
bitops/non-atomic: make @nr unsigned to avoid any DIV

signed math causes generation of costlier instructions such as DIV when
they could be done by barrerl shifter.

Worse part is this is not caught by things like bloat-o-meter since
instruction length / symbols are typically same size.

e.g.

stock (signed math)
__________________

919b4614 <test_taint>:
919b4614: div r2,r0,0x20
                ^^^
919b4618: add2 r2,0x920f6050,r2
919b4620: ld_s r2,[r2,0]
919b4622: lsr r0,r2,r0
919b4626: j_s.d [blink]
919b4628: bmsk_s r0,r0,0
919b462a: nop_s

(patched) unsigned math
__________________

919b4614 <test_taint>:
919b4614: lsr r2,r0,0x5  @nr/32
                ^^^
919b4618: add2 r2,0x920f6050,r2
919b4620: ld_s r2,[r2,0]
919b4622: lsr r0,r2,r0     #test_bit()
919b4626: j_s.d [blink]
919b4628: bmsk_s r0,r0,0
919b462a: nop_s

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
include/asm-generic/bitops/non-atomic.h