genetlink: hold read cb_lock during iteration of genl_fam_idr in genl_bind()
authorJiri Pirko <jiri@nvidia.com>
Thu, 25 Aug 2022 08:19:40 +0000 (10:19 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 27 Aug 2022 01:47:21 +0000 (18:47 -0700)
commit8f1948bdcf2fb50e9092c0950c3c9ac591382101
treec1226196268ab3fef0332a460132f84e31186594
parent0c1f77d87d699346f8e8a4874692eb82cbcf9c65
genetlink: hold read cb_lock during iteration of genl_fam_idr in genl_bind()

In genl_bind(), currently genl_lock and write cb_lock are taken
for iteration of genl_fam_idr and processing of static values
stored in struct genl_family. Take just read cb_lock for this task
as it is sufficient to guard the idr and the struct against
concurrent genl_register/unregister_family() calls.

This will allow to run genl command processing in genl_rcv() and
mnl_socket_setsockopt(.., NETLINK_ADD_MEMBERSHIP, ..) in parallel.

Reported-by: Vikas Gupta <vikas.gupta@broadcom.com>
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20220825081940.1283335-1-jiri@resnulli.us
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/netlink/genetlink.c