[libc++] Tidy up tests for deduction guides and other compile-time failing properties...
authorLouis Dionne <ldionne.2@gmail.com>
Mon, 4 Apr 2022 17:35:41 +0000 (13:35 -0400)
committerLouis Dionne <ldionne.2@gmail.com>
Tue, 5 Apr 2022 14:52:52 +0000 (10:52 -0400)
commit8ec4999766bedd3f3195f8c5eebe84ed9320bfe1
tree273127629074844c4f5527851ca70a4148f7bce6
parent516333d632ea7fc9f328520ac46337b7494271d4
[libc++] Tidy up tests for deduction guides and other compile-time failing properties in std::string

Instead of using `.fail.cpp` tests, use `.verify.cpp` to check for the
exact reason of the failure. In the case of deduction guides, use SFINAE
based tests instead since that is our preferred way of testing those.

Finally, ensure that we actually run the test in `iter_alloc_deduction.pass.cpp`,
since we were not running anything before.

Differential Revision: https://reviews.llvm.org/D123055
12 files changed:
libcxx/test/std/strings/basic.string/allocator_mismatch.verify.cpp [moved from libcxx/test/std/strings/basic.string/allocator_mismatch.compile.fail.cpp with 75% similarity]
libcxx/test/std/strings/basic.string/char.bad.fail.cpp [deleted file]
libcxx/test/std/strings/basic.string/char.bad.verify.cpp [new file with mode: 0644]
libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp [deleted file]
libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.pass.cpp
libcxx/test/std/strings/basic.string/string.cons/string_view.compile.fail.cpp [deleted file]
libcxx/test/std/strings/basic.string/string.cons/string_view.pass.cpp
libcxx/test/std/strings/basic.string/string.cons/string_view_deduction.fail.cpp [deleted file]
libcxx/test/std/strings/basic.string/string.cons/string_view_deduction.pass.cpp
libcxx/test/std/strings/basic.string/string.cons/string_view_size_size_deduction.fail.cpp [deleted file]
libcxx/test/std/strings/basic.string/string.cons/string_view_size_size_deduction.pass.cpp
libcxx/test/std/strings/basic.string/traits_mismatch.verify.cpp [moved from libcxx/test/std/strings/basic.string/traits_mismatch.compile.fail.cpp with 77% similarity]