scsi: ufs: Fix clkgating on/off
authorJaegeuk Kim <jaegeuk@kernel.org>
Tue, 17 Nov 2020 16:58:38 +0000 (08:58 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 Nov 2020 03:00:52 +0000 (22:00 -0500)
commit8eb456be75af7e5a7ac0cd223eaa198cf7ee2ac1
tree4a4cb3ff49e1107879107c9a8b113c54ffb8e257
parent69a314d6a155c5bfa9720b25d6456656f0b38bd1
scsi: ufs: Fix clkgating on/off

The following call stack prevents clk_gating at every I/O completion.  We
can remove the condition, ufshcd_any_tag_in_use(), since clkgating_work
will check it again.

ufshcd_complete_requests(struct ufs_hba *hba)
  ufshcd_transfer_req_compl()
    __ufshcd_transfer_req_compl()
      __ufshcd_release(hba)
        if (ufshcd_any_tag_in_use() == 1)
           return;
  ufshcd_tmc_handler(hba);
    blk_mq_tagset_busy_iter();

Note that this still requires work to deal with a potential race condition
when user sets clkgating.delay_ms to very small value. That can cause
preventing clkgating by the check of ufshcd_any_tag_in_use() in gate_work.

Link: https://lore.kernel.org/r/20201117165839.1643377-7-jaegeuk@kernel.org
Fixes: 7252a3603015 ("scsi: ufs: Avoid busy-waiting by eliminating tag conflicts")
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
Reviewed-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c