b43: Fix error in cordic routine
authorLarry Finger <Larry.Finger@lwfinger.net>
Mon, 19 Nov 2018 18:01:24 +0000 (20:01 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 29 Nov 2018 15:30:49 +0000 (17:30 +0200)
commit8ea3819c0bbef57a51d8abe579e211033e861677
tree5851ebd19460bc38d848e10281c4d67dbd09b4a8
parentea3edda9ddba634b9bcb8fcdcd95fe6b0a031a47
b43: Fix error in cordic routine

The cordic routine for calculating sines and cosines that was added in
commit 6f98e62a9f1b ("b43: update cordic code to match current specs")
contains an error whereby a quantity declared u32 can in fact go negative.

This problem was detected by Priit Laes who is switching b43 to use the
routine in the library functions of the kernel.

Fixes: 986504540306 ("b43: make cordic common (LP-PHY and N-PHY need it)")
Reported-by: Priit Laes <plaes@plaes.org>
Cc: Rafał Miłecki <zajec5@gmail.com>
Cc: Stable <stable@vger.kernel.org> # 2.6.34
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/b43/phy_common.c