ALSA: hda: enable regmap internal locking
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Wed, 8 Jan 2020 18:08:56 +0000 (20:08 +0200)
committerTakashi Iwai <tiwai@suse.de>
Wed, 8 Jan 2020 19:10:08 +0000 (20:10 +0100)
commit8e85def5723eccea30ebf22645673692ab8cb3e2
tree8cdf1af290e15b00d56659916e9213282d7931e4
parent54a6a7dc107da0492a9e84fd7e9a107b3c58138d
ALSA: hda: enable regmap internal locking

This reverts commit 42ec336f1f9d ("ALSA: hda: Disable regmap
internal locking").

Without regmap locking, there is a race between snd_hda_codec_amp_init()
and PM callbacks issuing regcache_sync(). This was caught by
following kernel warning trace:

<4> [358.080081] WARNING: CPU: 2 PID: 4157 at drivers/base/regmap/regcache.c:498 regcache_cache_only+0xf5/0x130
[...]
<4> [358.080148] Call Trace:
<4> [358.080158]  snd_hda_codec_amp_init+0x4e/0x100 [snd_hda_codec]
<4> [358.080169]  snd_hda_codec_amp_init_stereo+0x40/0x80 [snd_hda_codec]

Suggested-by: Takashi Iwai <tiwai@suse.de>
BugLink: https://gitlab.freedesktop.org/drm/intel/issues/592
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200108180856.5194-1-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/hdac_regmap.c