projects / platform / upstream / nodejs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 21911db) | patch
crypto: make root_cert_store variable extern
authorBen Noordhuis <info@bnoordhuis.nl>
Thu, 29 Aug 2013 12:05:42 +0000 (14:05 +0200)
committerBen Noordhuis <info@bnoordhuis.nl>
Thu, 29 Aug 2013 12:05:44 +0000 (14:05 +0200)
commit8e596c4e15f64b53d66e91079ed733821fb3e88d
tree5512f5e19ab5a5279bc00ddaf94e9c4a5590bbc0tree | snapshot
parent21911db392d8118372b92d0db1d92a031f481d61commit | diff
crypto: make root_cert_store variable extern

Before this commit it was declared static (in a header file!), meaning
it got duplicated in every file that includes it.

A few duplicated pointers is not the end of the world but it introduces
a lot of potential for confusion because root_cert_store in file A is
not the root_cert_store in file B.

Moral of the story: don't declare static variables in header files.
src/node_crypto.cc diff | blob | history
src/node_crypto.h diff | blob | history
Domain: Web Framework / Common;