tty: serial: fsl_lpuart: clear receive flag on FIFO flush
authorStefan Agner <stefan@agner.ch>
Fri, 13 Mar 2015 13:51:51 +0000 (14:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Mar 2015 22:13:14 +0000 (23:13 +0100)
commit8e4934c6d6c659e22b1b746af4196683e77ce6ca
treebb4fa80f0767f0c7f8a9ff52707865460bd5fe2d
parent4e8f245937091b2c9eebf3d4909c9ceda4f0a78e
tty: serial: fsl_lpuart: clear receive flag on FIFO flush

When the receiver was enabled during startup, a character could
have been in the FIFO when the UART get initially used. The
driver configures the (receive) watermark level, and flushes the
FIFO. However, the receive flag (RDRF) could still be set at that
stage (as mentioned in the register description of UARTx_RWFIFO).
This leads to an interrupt which won't be handled properly in
interrupt mode: The receive interrupt function lpuart_rxint checks
the FIFO count, which is 0 at that point (due to the flush
during initialization). The problem does not manifest when using
DMA to receive characters.

Fix this situation by explicitly read the status register, which
leads to clearing of the RDRF flag. Due to the flush just after
the status flag read, a explicit data read is not to required.

Signed-off-by: Stefan Agner <stefan@agner.ch>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/fsl_lpuart.c