blk-mq: I/O and timer unplugs are inverted in blktrace
authorIlya Dryomov <idryomov@gmail.com>
Wed, 26 Sep 2018 12:35:50 +0000 (14:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Oct 2018 07:27:22 +0000 (09:27 +0200)
commit8e2e2192eb35eb24eb99f120b78eed0b104092b2
tree76674bd5ec6033d3c0cba90437c437b1938f4a4a
parent87a9d1cc2e8f0a442ed1f219d36446398c5e24df
blk-mq: I/O and timer unplugs are inverted in blktrace

commit 587562d0c7cd6861f4f90a2eb811cccb1a376f5f upstream.

trace_block_unplug() takes true for explicit unplugs and false for
implicit unplugs.  schedule() unplugs are implicit and should be
reported as timer unplugs.  While correct in the legacy code, this has
been inverted in blk-mq since 4.11.

Cc: stable@vger.kernel.org
Fixes: bd166ef183c2 ("blk-mq-sched: add framework for MQ capable IO schedulers")
Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
block/blk-mq.c