sched/fair: Fix overutilized update in enqueue_task_fair()
authorQuentin Perret <qperret@google.com>
Thu, 12 Nov 2020 11:12:01 +0000 (11:12 +0000)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 17 Nov 2020 12:15:27 +0000 (13:15 +0100)
commit8e1ac4299a6e8726de42310d9c1379f188140c71
tree8eb8454794c58a9978cc4f09886fbe5af764fd7f
parent8d4d9c7b4333abccb3bf310d76ef7ea2edb9828f
sched/fair: Fix overutilized update in enqueue_task_fair()

enqueue_task_fair() attempts to skip the overutilized update for new
tasks as their util_avg is not accurate yet. However, the flag we check
to do so is overwritten earlier on in the function, which makes the
condition pretty much a nop.

Fix this by saving the flag early on.

Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point indicator")
Reported-by: Rick Yiu <rickyiu@google.com>
Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lkml.kernel.org/r/20201112111201.2081902-1-qperret@google.com
kernel/sched/fair.c