Fix overloading of "source" and "target" terminology in GBinding
authorDan Winship <danw@gnome.org>
Fri, 4 Oct 2013 16:58:48 +0000 (12:58 -0400)
committerDan Winship <danw@gnome.org>
Sun, 6 Oct 2013 18:24:43 +0000 (14:24 -0400)
commit8e17040c159bf0a7cf060f12e467a0ad1f5b6741
tree0526db30ee78b939964fa6e87be5a78457d46097
parentbe7f40185fb2ce884112c1f8a4b196ea65350466
Fix overloading of "source" and "target" terminology in GBinding

GBindingTransformFunc called its arguments "source_value" and
"target_value", but in the transform_from function of a bidirectional
binding, "source_value" comes from the target object, and
"target_value" comes from the source object, which quickly gets
confusing if you need to use g_binding_get_source(), etc, in the
function.

Of course developers can call their transform function arguments
whatever they want, but many will copy from the headers/docs to start
out, so use less confusing names here ("from_value" and "to_value").

Also, fix the documentation to describe the bidirectional case
correctly.

https://bugzilla.gnome.org/show_bug.cgi?id=709440
gobject/gbinding.c
gobject/gbinding.h
gobject/tests/binding.c