NFSD: Fix ia_size underflow
authorChuck Lever <chuck.lever@oracle.com>
Mon, 31 Jan 2022 18:01:53 +0000 (13:01 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Feb 2022 11:56:06 +0000 (12:56 +0100)
commit8e0ecaf7a7e57b30284d6b3289cc436100fadc48
tree9ae2544ffb244f11017726ef298e2c4ce959c8a5
parent37f2d2cd8eadddbbd9c7bda327a9393399b2f89b
NFSD: Fix ia_size underflow

commit e6faac3f58c7c4176b66f63def17a34232a17b0e upstream.

iattr::ia_size is a loff_t, which is a signed 64-bit type. NFSv3 and
NFSv4 both define file size as an unsigned 64-bit type. Thus there
is a range of valid file size values an NFS client can send that is
already larger than Linux can handle.

Currently decode_fattr4() dumps a full u64 value into ia_size. If
that value happens to be larger than S64_MAX, then ia_size
underflows. I'm about to fix up the NFSv3 behavior as well, so let's
catch the underflow in the common code path: nfsd_setattr().

Cc: stable@vger.kernel.org
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfsd/vfs.c