usb: gadget: uvc: Only halt video streaming endpoint in bulk mode
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 10 Aug 2018 12:44:57 +0000 (15:44 +0300)
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 25 Sep 2018 15:39:00 +0000 (18:39 +0300)
commit8dbf9c7abefd5c1434a956d5c6b25e11183061a3
tree11aefea87ac844fbc0311eae9df364640e4e01f0
parent9d1ff5dcb3cd3390b1e56f1c24ae42c72257c4a3
usb: gadget: uvc: Only halt video streaming endpoint in bulk mode

When USB requests for video data fail to be submitted, the driver
signals a problem to the host by halting the video streaming endpoint.
This is only valid in bulk mode, as isochronous transfers have no
handshake phase and can't thus report a stall. The usb_ep_set_halt()
call returns an error when using isochronous endpoints, which we happily
ignore, but some UDCs complain in the kernel log. Fix this by only
trying to halt the endpoint in bulk mode.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Tested-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
drivers/usb/gadget/function/uvc_video.c