ASoC: qcom: cleanup and fix dependency of QCOM_COMMON
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thu, 24 Nov 2022 14:03:51 +0000 (14:03 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 24 Nov 2022 15:29:34 +0000 (15:29 +0000)
commit8d89cf6ff229ff31cd4f73f5b3928564b81fc41e
treed1fb1327f7dbc4ad6a7018b2463d19a711aa71a3
parent1bf5ee979076ceb121ee51c95197d890b1cee7f4
ASoC: qcom: cleanup and fix dependency of QCOM_COMMON

SND_SOC_QCOM_COMMON depends on SOUNDWIRE for some symbols but this
is not explicitly specified using Kconfig depends. On the other hand
SND_SOC_QCOM_COMMON is also directly selected by the sound card
Kconfigs, this could result in various combinations and some symbols
ending up in modules and soundcard that uses those symbols as in-build
driver.

Fix these issues by explicitly specifying the dependencies of
SND_SOC_QCOM_COMMON and also use imply a to select SND_SOC_QCOM_COMMON
so that the symbol is selected based on its dependencies.

Also remove dummy stubs in common.c around CONFIG_SOUNDWIRE

Fixes: 3bd975f3ae0a ("ASoC: qcom: sm8250: move some code to common")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20221124140351.407506-1-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/Kconfig
sound/soc/qcom/common.c
sound/soc/qcom/common.h