nmi_backtrace: allow excluding an arbitrary CPU
authorDouglas Anderson <dianders@chromium.org>
Fri, 4 Aug 2023 14:00:42 +0000 (07:00 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 18 Aug 2023 17:19:00 +0000 (10:19 -0700)
commit8d539b84f1e3478436f978ceaf55a0b6cab497b5
tree305d70872637b1eb8f771dba5b4b408a469ea3b4
parent3c9d017cc283df0dabf6b16a6cb4574426cbd53b
nmi_backtrace: allow excluding an arbitrary CPU

The APIs that allow backtracing across CPUs have always had a way to
exclude the current CPU.  This convenience means callers didn't need to
find a place to allocate a CPU mask just to handle the common case.

Let's extend the API to take a CPU ID to exclude instead of just a
boolean.  This isn't any more complex for the API to handle and allows the
hardlockup detector to exclude a different CPU (the one it already did a
trace for) without needing to find space for a CPU mask.

Arguably, this new API also encourages safer behavior.  Specifically if
the caller wants to avoid tracing the current CPU (maybe because they
already traced the current CPU) this makes it more obvious to the caller
that they need to make sure that the current CPU ID can't change.

[akpm@linux-foundation.org: fix trigger_allbutcpu_cpu_backtrace() stub]
Link: https://lkml.kernel.org/r/20230804065935.v4.1.Ia35521b91fc781368945161d7b28538f9996c182@changeid
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: kernel test robot <lkp@intel.com>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Pingfan Liu <kernelfans@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
16 files changed:
arch/arm/include/asm/irq.h
arch/arm/kernel/smp.c
arch/loongarch/include/asm/irq.h
arch/loongarch/kernel/process.c
arch/mips/include/asm/irq.h
arch/mips/kernel/process.c
arch/powerpc/include/asm/irq.h
arch/powerpc/kernel/stacktrace.c
arch/powerpc/kernel/watchdog.c
arch/sparc/include/asm/irq_64.h
arch/sparc/kernel/process_64.c
arch/x86/include/asm/irq.h
arch/x86/kernel/apic/hw_nmi.c
include/linux/nmi.h
kernel/watchdog.c
lib/nmi_backtrace.c