accel/qaic: Call DRM helper function to destroy prime GEM
authorPranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Wed, 14 Jun 2023 16:15:28 +0000 (10:15 -0600)
committerJeffrey Hugo <quic_jhugo@quicinc.com>
Tue, 20 Jun 2023 14:07:29 +0000 (08:07 -0600)
commit8d0d16a3ef44c60d66f937c21f32fa2cf8f2c9ed
tree42e03d915b885d2d3f1fee9beecb6dc82257d732
parent45a3e24f65e90a047bef86f927ebdc4c710edaa1
accel/qaic: Call DRM helper function to destroy prime GEM

smatch warning:
drivers/accel/qaic/qaic_data.c:620 qaic_free_object() error:
dereferencing freed memory 'obj->import_attach'

obj->import_attach is detached and freed using dma_buf_detach().
But used after free to decrease the dmabuf ref count using
dma_buf_put().

drm_prime_gem_destroy() handles this issue and performs the proper clean
up instead of open coding it in the driver.

Fixes: ff13be830333 ("accel/qaic: Add datapath")
Reported-by: Sukrut Bellary <sukrut.bellary@linux.com>
Closes: https://lore.kernel.org/all/20230610021200.377452-1-sukrut.bellary@linux.com/
Suggested-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230614161528.11710-1-quic_jhugo@quicinc.com
drivers/accel/qaic/qaic_data.c