SCEVExpander::expandAddRecExprLiterally(): check before casting as Instruction
authorRoman Lebedev <lebedev.ri@gmail.com>
Fri, 29 Jun 2018 07:44:20 +0000 (07:44 +0000)
committerRoman Lebedev <lebedev.ri@gmail.com>
Fri, 29 Jun 2018 07:44:20 +0000 (07:44 +0000)
commit8d081b78e4e929fa0bf3ea44d2ce41c64dc641c7
treee4f5ed420e750727124d0a4b1c159ff95d5da781
parentec1a3048a30dd86d33b2ebdc475d767743aca049
SCEVExpander::expandAddRecExprLiterally(): check before casting as Instruction

Summary:
An alternative to D48597.
Fixes [[ https://bugs.llvm.org/show_bug.cgi?id=37936 | PR37936 ]].

The problem is as follows:
1. `indvars` marks `%dec` as `NUW`.
2. `loop-instsimplify` runs `instsimplify`, which constant-folds `%dec` to -1 (D47908)
3. `loop-reduce` tries to do some further modification, but crashes
    with an type assertion in cast, because `%dec` is no longer an `Instruction`,

If the runline is split into two, i.e. you first run `-indvars -loop-instsimplify`,
store that into a file, and then run `-loop-reduce`, there is no crash.

So it looks like the problem is due to `-loop-instsimplify` not discarding SCEV.
But in this case we can just not crash if it's not an `Instruction`.
This is just a local fix, unlike D48597, so there may very well be other problems.

Reviewers: mkazantsev, uabelho, sanjoy, silviu.baranga, wmi

Reviewed By: mkazantsev

Subscribers: evstupac, javed.absar, spatel, llvm-commits

Differential Revision: https://reviews.llvm.org/D48599

llvm-svn: 335950
llvm/lib/Analysis/ScalarEvolutionExpander.cpp
llvm/test/Transforms/LoopStrengthReduce/scev-after-loopinstsimplify.ll [new file with mode: 0644]