dmaengine: idxd: Fix issues with PRS disable sysfs knob
authorFenghua Yu <fenghua.yu@intel.com>
Fri, 11 Aug 2023 01:26:35 +0000 (18:26 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 21 Aug 2023 13:26:31 +0000 (18:56 +0530)
commit8cae66574398326134a41513b419e00ad4e380ca
tree7ffcfa1bb7adf68d1b663998875c648edb1057f5
parent0056a7f07b0a63e6cee815a789eabba6f3a710f0
dmaengine: idxd: Fix issues with PRS disable sysfs knob

There are two issues in the current PRS disable sysfs store function
wq_prs_disable_store():

1. Since PRS disable knob is invisible if PRS disable is not supported
   in WQ, it's redundant to check PRS support again in the store function
   again. Remove the redundant PRS support check.
2. Since PRS disable is read-only when the device is not configurable,
   PRS disable cannot be changed on the device. Add device configurable
   check in the store function.

Fixes: f2dc327131b5 ("dmaengine: idxd: add per wq PRS disable")
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20230811012635.535413-2-fenghua.yu@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/sysfs.c