Fix SPARC64 handling of R_SPARC_H34 (bug 24231).
authorJoseph Myers <joseph@codesourcery.com>
Mon, 18 Feb 2019 22:33:29 +0000 (22:33 +0000)
committerJoseph Myers <joseph@codesourcery.com>
Mon, 18 Feb 2019 22:33:29 +0000 (22:33 +0000)
commit8c9289b64271639661e5dbe3c19c0badc9db9cfa
treef523846a9aba437bc8682289591ee34793183300
parent308e022fc46a944700ad5a41530f36aaa6cc7dae
Fix SPARC64 handling of R_SPARC_H34 (bug 24231).

Building glibc with -Wextra shows a -Wimplicit-fallthrough warning for
SPARC64 that appears to be a real bug in glibc.  The dynamic linker
handling of R_SPARC_H34 falls through to that of R_SPARC_H44, which in
the case of this code is nonsensical (it means the value computed for
R_SPARC_H34 gets overwritten by one computed with the different logic
for R_SPARC_H44).  Thus, this patch adds the missing break there.
Note: I do not have a testcase to demonstrate this bug.

Tested with build-many-glibcs.py.

[BZ #24231]
* sysdeps/sparc/sparc64/dl-machine.h (elf_machine_rela): Add break
after R_SPARC_H34 case.
ChangeLog
sysdeps/sparc/sparc64/dl-machine.h