Partially revert "xwayland: Always free reply from xcb_get_property_reply()"
authorEmmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Wed, 15 Jul 2015 20:19:04 +0000 (22:19 +0200)
committerBryce Harrington <bryce@osg.samsung.com>
Wed, 15 Jul 2015 20:55:58 +0000 (13:55 -0700)
commit8c7287f5ba67d2a3116c7ec1c9c012b8f34a4423
tree11acadf7cfaa2f6df6c1d319de330bb96c122e27
parenta820b4d635854fb1bf21bc7a25d13a0599ce15ce
Partially revert "xwayland: Always free reply from xcb_get_property_reply()"

This reverts commit d3553c721c0fed07f85b70fea418ca65ed974fbb.

weston_wm_write_property() takes the ownership of the reply it gets as
a parameter, and will eventually free it later in writable_callback.

This change introduced a double-free when Xwayland programs triggered a
copy to the clipboard, leading to a Weston crash.

Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>
xwayland/selection.c