In README.md CMAKE_PREFIX_PATH should be CONDA_PREFIX when using an conda virtual...
authorderek <bluewhale8202@gmail.com>
Wed, 26 Dec 2018 20:54:17 +0000 (12:54 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Wed, 26 Dec 2018 20:57:07 +0000 (12:57 -0800)
commit8c6ff91d571c34e40ee12dbfe16499b2df2f7440
tree0ee84c5c9c3b088c2772c533e4025392624b7072
parentcdb8edce7572342cf6f5d98807678e9ed3a1a32e
In README.md CMAKE_PREFIX_PATH should be CONDA_PREFIX when using an conda virtual environment (#15548)

Summary:
In current README.md, `CMAKE_PREFIX_PATH` is set to conda root even when you have activated an virtual environment. When an conda virtualenv is activated, packages are installed in `CONDA_PREFIX`, not conda root. I think `CMAKE_PREFIX_PATH` should also be set to `CONDA_PREFIX` in this case. I think some build issues can be solved with the new instruction. Maybe something like #14954.

soumith,
When I made PR #15335 I was confused and made a wrong point. I think this PR could be the real solution.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/15548

Differential Revision: D13549681

Pulled By: soumith

fbshipit-source-id: 42d855b6e49ee58d735d2f4715d3e5752a748693
README.md