nvme-fc: Revert "add module to ops template to allow module references"
authorJames Smart <jsmart2021@gmail.com>
Fri, 3 Apr 2020 14:33:20 +0000 (07:33 -0700)
committerChristoph Hellwig <hch@lst.de>
Sat, 4 Apr 2020 07:09:39 +0000 (09:09 +0200)
commit8c5c660529209a0e324c1c1a35ce3f83d67a2aa5
treef2d9ed8ed3cf9403e6b35b977a6329f12cf1b6c7
parent657f1975e9d9c880fa13030e88ba6cc84964f1db
nvme-fc: Revert "add module to ops template to allow module references"

The original patch was to resolve the lldd being able to be unloaded
while being used to talk to the boot device of the system. However, the
end result of the original patch is that any driver unload while a nvme
controller is live via the lldd is now being prohibited. Given the module
reference, the module teardown routine can't be called, thus there's no
way, other than manual actions to terminate the controllers.

Fixes: 863fbae929c7 ("nvme_fc: add module to ops template to allow module references")
Cc: <stable@vger.kernel.org> # v5.4+
Signed-off-by: James Smart <jsmart2021@gmail.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/fc.c
drivers/nvme/target/fcloop.c
drivers/scsi/lpfc/lpfc_nvme.c
drivers/scsi/qla2xxx/qla_nvme.c
include/linux/nvme-fc-driver.h