net/tcp: Fix socket lookups with SO_BINDTODEVICE
authorDavid Ahern <dsahern@gmail.com>
Mon, 18 Jun 2018 19:30:37 +0000 (12:30 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Jun 2018 23:03:06 +0000 (08:03 +0900)
commit8c43bd1706885ba1acfa88da02bc60a2ec16f68c
treeeb62f5e69eaf9c60c5a18c2427cf9ed9804c7e7b
parentf696a21c229ac3e85bc239efc52f4530b43002c5
net/tcp: Fix socket lookups with SO_BINDTODEVICE

Similar to 69678bcd4d2d ("udp: fix SO_BINDTODEVICE"), TCP socket lookups
need to fail if dev_match is not true. Currently, a packet to a given port
can match a socket bound to device when it should not. In the VRF case,
this causes the lookup to hit a VRF socket and not a global socket
resulting in a response trying to go through the VRF when it should not.

Fixes: 3fa6f616a7a4d ("net: ipv4: add second dif to inet socket lookups")
Fixes: 4297a0ef08572 ("net: ipv6: add second dif to inet6 socket lookups")
Reported-by: Lou Berger <lberger@labn.net>
Diagnosed-by: Renato Westphal <renato@opensourcerouting.org>
Tested-by: Renato Westphal <renato@opensourcerouting.org>
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_hashtables.c
net/ipv6/inet6_hashtables.c