x86/entry: Use PUSH_AND_CLEAR_REGS for compat
authorPeter Zijlstra <peterz@infradead.org>
Fri, 6 May 2022 12:14:34 +0000 (14:14 +0200)
committerBorislav Petkov <bp@suse.de>
Fri, 6 May 2022 13:57:02 +0000 (15:57 +0200)
commit8c42819b61b8340cff0643e65b5ce6a4144ab155
tree004465a4e2c22446f5396768f49c5f197720c71f
parentd205222eb6a8e5e70c21200beb81c6e19ec211d6
x86/entry: Use PUSH_AND_CLEAR_REGS for compat

Since the upper regs don't exist for ia32 code, preserving them
doesn't hurt and it simplifies the code.

This doesn't add any attack surface that would not already be
available through INT80.

Notably:

 - 32bit SYSENTER: didn't clear si, dx, cx.

 - 32bit SYSCALL, INT80: *do* clear si since the C functions don't
   take a second argument.

 - 64bit: didn't clear si since the C functions take a second
   argument; except the error_entry path might have only one argument,
   so clearing si was missing here.

32b SYSENTER should be clearing all those 3 registers, nothing uses them
and selftests pass.

Unconditionally clear rsi since it simplifies code.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220506121631.293889636@infradead.org
arch/x86/entry/calling.h
arch/x86/entry/entry_64_compat.S