CSS Shaders: Remove the setTimeout from the layout tests
authorachicu@adobe.com <achicu@adobe.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 19 Jan 2012 23:20:53 +0000 (23:20 +0000)
committerachicu@adobe.com <achicu@adobe.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 19 Jan 2012 23:20:53 +0000 (23:20 +0000)
commit8c3c04048758e85c68122fd087c5ca02a58bf8c2
tree0df546b852b7fec259a8fec28021b79d6d5eb458
parentbce2388e1b0674df52a7c808948ea139da85737b
CSS Shaders: Remove the setTimeout from the layout tests
https://bugs.webkit.org/show_bug.cgi?id=76535

Reviewed by Tony Chang.

Source/WebCore:

We had setTimeout on old tests because the snapshot picture was taken too early, before the shaders were loaded.
The problem was that the RenderLayer was notified that the shader was loaded only after the onload event was triggered,
so a simple setTimeout(0) would have fixed the issue, but better than that would be to to always call CachedResource::data
in CachedShader::data, which notifies the load earlier (before onload).

No new tests, just removed the setTimeout from old ones.

* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::data):

LayoutTests:

No need for setTimeout anymore, so I've removed them from the custom filter tests.

* css3/filters/custom-filter-shader-cache.html:
* css3/filters/effect-custom-combined-missing.html:
* css3/filters/effect-custom-parameters.html:
* css3/filters/effect-custom.html:
* css3/filters/missing-custom-filter-shader.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/css3/filters/custom-filter-shader-cache.html
LayoutTests/css3/filters/effect-custom-combined-missing.html
LayoutTests/css3/filters/effect-custom-parameters.html
LayoutTests/css3/filters/effect-custom.html
LayoutTests/css3/filters/missing-custom-filter-shader.html
Source/WebCore/ChangeLog
Source/WebCore/loader/cache/CachedShader.cpp