efl_ui_selection_manager: fix potential out of bounce access
authorStefan Schmidt <s.schmidt@samsung.com>
Tue, 24 Sep 2019 20:56:48 +0000 (16:56 -0400)
committerJongmin Lee <jm105.lee@samsung.com>
Tue, 24 Sep 2019 21:50:43 +0000 (06:50 +0900)
commit8c3a3c690564e8424f7d451e97278b18883d9b43
tree03108b59518116f33e0eb5c38b4d2054b0376127
parent4149a19b769d642dd5f8262c20e0e76e16aadde7
efl_ui_selection_manager: fix potential out of bounce access

Summary:
We have been casting the selection to unsigned char * for the address of
sel and not for the value. Coverity pointed this out:
Overrunning buffer pointed to by (unsigned char *)&sel of 8 bytes by
passing it to a function which accesses it at byte offset 167 using argument 168

It seems this has been working by memory layout and luck if I understand
it all correctly.

Coverity ID: 1402666

Reviewers: thiepha, raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10107
src/lib/elementary/efl_ui_selection_manager.c