ext4: avoid drop reference to iloc.bh twice
authorPan Bian <bianpan2016@163.com>
Thu, 25 Apr 2019 15:44:15 +0000 (11:44 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 25 Apr 2019 15:44:15 +0000 (11:44 -0400)
commit8c380ab4b7b59c0c602743810be1b712514eaebc
tree219607cef9f919264702e71af75fac9d3e0a0f76
parente5d01196c0428a206f307e9ee5f6842964098ff0
ext4: avoid drop reference to iloc.bh twice

The reference to iloc.bh has been dropped in ext4_mark_iloc_dirty.
However, the reference is dropped again if error occurs during
ext4_handle_dirty_metadata, which may result in use-after-free bugs.

Fixes: fb265c9cb49e("ext4: add ext4_sb_bread() to disambiguate ENOMEM cases")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: stable@kernel.org
fs/ext4/resize.c