Bluetooth: Fix controller configuration with HCI_QUIRK_INVALID_BDADDR
authorMarcel Holtmann <marcel@holtmann.org>
Tue, 23 Dec 2014 22:10:48 +0000 (23:10 +0100)
committerJohan Hedberg <johan.hedberg@intel.com>
Wed, 24 Dec 2014 18:35:46 +0000 (20:35 +0200)
commit8bfe8442ff20fdc2d965c197103d935a99bd3296
tree7b92dcd07f0ca0710425ff53bc51e31d18555972
parent71bb99a02b32b4cc4265118e85f6035ca72923f0
Bluetooth: Fix controller configuration with HCI_QUIRK_INVALID_BDADDR

When controllers set the HCI_QUIRK_INVALID_BDADDR flag, it is required
by userspace to program a valid public Bluetooth device address into
the controller before it can be used.

After successful address configuration, the internal state changes and
the controller runs the complete initialization procedure. However one
small difference is that this is no longer the HCI_SETUP stage. The
HCI_SETUP stage is only valid during initial controller setup. In this
case the stack runs the initialization as part of the HCI_CONFIG stage.

The controller version information, default name and supported commands
are only stored during HCI_SETUP. While these information are static,
they are not read initially when HCI_QUIRK_INVALID_BDADDR is set. So
when running in HCI_CONFIG state, these information need to be updated
as well.

This especially impacts Bluetooth 4.1 and later controllers using
extended feature pages and second event mask page.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Cc: stable@vger.kernel.org # 3.17+
net/bluetooth/hci_event.c