cxl: fix possible null-ptr-deref in cxl_pci_init_afu|adapter()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 11 Nov 2022 14:54:40 +0000 (22:54 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 24 Nov 2022 12:31:25 +0000 (23:31 +1100)
commit8bf03f557d6c6e108cf47bea32f4a68e276e1157
tree9c7c011995b22b280d4a28fc787a4d0970438c55
parentf949ccee1dde970bc77dc871b4f0b5e651577344
cxl: fix possible null-ptr-deref in cxl_pci_init_afu|adapter()

If device_register() fails in cxl_pci_afu|adapter(), the device
is not added, device_unregister() can not be called in the error
path, otherwise it will cause a null-ptr-deref because of removing
not added device.

As comment of device_register() says, it should use put_device() to give
up the reference in the error path. So split device_unregister() into
device_del() and put_device(), then goes to put dev when register fails.

Fixes: f204e0b8cedd ("cxl: Driver code for powernv PCIe based cards for userspace access")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221111145440.2426970-2-yangyingliang@huawei.com
drivers/misc/cxl/pci.c