[libc++][Apple] Use CLOCK_MONOTONIC_RAW instead of CLOCK_UPTIME_RAW for steady_clock
authorLouis Dionne <ldionne@apple.com>
Mon, 10 Feb 2020 17:30:43 +0000 (18:30 +0100)
committerLouis Dionne <ldionne@apple.com>
Wed, 12 Feb 2020 15:43:36 +0000 (16:43 +0100)
commit8bec8927134f116eb11ddea9db78b1a6241884c9
treebc7d8965054b683ee396d5241cb092131794db47
parentfc8d033e966305ebed3ffcd7c633d6e9ebef10ae
[libc++][Apple] Use CLOCK_MONOTONIC_RAW instead of CLOCK_UPTIME_RAW for steady_clock

Summary:
In D27429, we switched the Apple implementation of steady_clock::now()
from clock_gettime(CLOCK_MONOTONIC) to clock_gettime(CLOCK_UPTIME_RAW).
The purpose was to get nanosecond precision, and also to improve the
performance of the implementation.

However, it appears that CLOCK_UPTIME_RAW does not satisfy the requirements
of the Standard, since it is not strictly speaking monotonic. Indeed, the
clock does not increment while the system is asleep, which had been
mentioned in D27429 but somehow not addressed.

This patch switches to CLOCK_MONOTONIC_RAW, which is monotonic, increased
during sleep, and also has nanosecond precision.

https://llvm.org/PR44773

Reviewers: bruno, howard.hinnant, EricWF

Subscribers: christof, jkorous, dexonsmith, libcxx-commits, mclow.lists, EricWF

Tags: #libc

Differential Revision: https://reviews.llvm.org/D74341
libcxx/src/chrono.cpp