target_stack -> current_top_target() throughout
authorPedro Alves <palves@redhat.com>
Thu, 7 Jun 2018 16:27:46 +0000 (17:27 +0100)
committerPedro Alves <palves@redhat.com>
Thu, 7 Jun 2018 16:27:46 +0000 (17:27 +0100)
commit8b88a78e63526b84d540b9c7d5f459593a248d5e
tree3d1a43354d8b4cb169f2f9cff422531daee350b2
parentc7110220be62590222e35525dda499902ee49a89
target_stack -> current_top_target() throughout

The recent C++ification of target_ops replaced references to the old
"current_target" squashed target throughout with references to a
"target_stack" pointer.  I had picked the "target_stack" name very
early in the multi-target work, and managed to stick with it, even
though it's a bit of a misnomer, since it isn't really a "target
stack" object, but a pointer into the current top target in the stack.
As I'm splitting more pieces off of the multi-target branch, I've come
to think that it's better to rename it now.  A following patch will
introduce a new class to represent a target stack, and "target_stack"
would be _its_ ideal name.  (In the branch, the class is called
a_target_stack to work around the clash.)

Thus this commit renames target_stack to current_top_target and
replaces all references throughout.  Also, while at it,
current_top_target is made a function instead of a pointer, to make it
possible to change its internal implementation without leaking
implementation details out.  In a couple patches, the implementation
of the function will change to refer to a target stack object, and
then further down the multi-target work, it'll change again to find
the right target stack for the current inferior.

gdb/ChangeLog:
2018-06-07  Pedro Alves  <palves@redhat.com>

* target.h (target_stack): Delete.
(current_top_target): Declare function.
* target.c (target_stack): Delete.
(g_current_top_target): New.
(current_top_target): New function.
* auxv.c: Use current_top_target instead of target_stack
throughout.
* avr-tdep.c: Likewise.
* breakpoint.c: Likewise.
* corefile.c: Likewise.
* elfread.c: Likewise.
* eval.c: Likewise.
* exceptions.c: Likewise.
* frame.c: Likewise.
* gdbarch-selftests.c: Likewise.
* gnu-v3-abi.c: Likewise.
* ia64-tdep.c: Likewise.
* ia64-vms-tdep.c: Likewise.
* infcall.c: Likewise.
* infcmd.c: Likewise.
* infrun.c: Likewise.
* linespec.c: Likewise.
* linux-tdep.c: Likewise.
* minsyms.c: Likewise.
* ppc-linux-nat.c: Likewise.
* ppc-linux-tdep.c: Likewise.
* procfs.c: Likewise.
* regcache.c: Likewise.
* remote.c: Likewise.
* rs6000-tdep.c: Likewise.
* s390-linux-nat.c: Likewise.
* s390-tdep.c: Likewise.
* solib-aix.c: Likewise.
* solib-darwin.c: Likewise.
* solib-dsbt.c: Likewise.
* solib-spu.c: Likewise.
* solib-svr4.c: Likewise.
* solib-target.c: Likewise.
* sparc-tdep.c: Likewise.
* sparc64-tdep.c: Likewise.
* spu-tdep.c: Likewise.
* symfile.c: Likewise.
* symtab.c: Likewise.
* target-descriptions.c: Likewise.
* target-memory.c: Likewise.
* target.c: Likewise.
* target.h: Likewise.
* tracefile-tfile.c: Likewise.
* tracepoint.c: Likewise.
* valops.c: Likewise.
* valprint.c: Likewise.
* value.c: Likewise.
* windows-tdep.c: Likewise.
* mi/mi-main.c: Likewise.
49 files changed:
gdb/ChangeLog
gdb/auxv.c
gdb/avr-tdep.c
gdb/breakpoint.c
gdb/corefile.c
gdb/elfread.c
gdb/eval.c
gdb/exceptions.c
gdb/frame.c
gdb/gdbarch-selftests.c
gdb/gnu-v3-abi.c
gdb/ia64-tdep.c
gdb/ia64-vms-tdep.c
gdb/infcall.c
gdb/infcmd.c
gdb/infrun.c
gdb/linespec.c
gdb/linux-tdep.c
gdb/mi/mi-main.c
gdb/minsyms.c
gdb/ppc-linux-nat.c
gdb/ppc-linux-tdep.c
gdb/procfs.c
gdb/regcache.c
gdb/remote.c
gdb/rs6000-tdep.c
gdb/s390-linux-nat.c
gdb/s390-tdep.c
gdb/solib-aix.c
gdb/solib-darwin.c
gdb/solib-dsbt.c
gdb/solib-spu.c
gdb/solib-svr4.c
gdb/solib-target.c
gdb/sparc-tdep.c
gdb/sparc64-tdep.c
gdb/spu-tdep.c
gdb/symfile.c
gdb/symtab.c
gdb/target-descriptions.c
gdb/target-memory.c
gdb/target.c
gdb/target.h
gdb/tracefile-tfile.c
gdb/tracepoint.c
gdb/valops.c
gdb/valprint.c
gdb/value.c
gdb/windows-tdep.c